Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): add spacing input field and number input #636

Merged
merged 17 commits into from
Sep 1, 2023

Conversation

nina992
Copy link
Contributor

@nina992 nina992 commented Aug 23, 2023

Overview

Add the spacing field to field component set

Screenshots

image

What I've done

What I haven't done

How I tested

Which point I want you to review particularly

Memo

@nina992 nina992 requested a review from KaWaite as a code owner August 23, 2023 06:29
@netlify
Copy link

netlify bot commented Aug 23, 2023

Deploy Preview for reearth-web ready!

Name Link
🔨 Latest commit ad5fa8b
🔍 Latest deploy log https://app.netlify.com/sites/reearth-web/deploys/64f0582e8904960008b7a22b
😎 Deploy Preview https://deploy-preview-636--reearth-web.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the web label Aug 23, 2023
@github-actions github-actions bot requested a review from pyshx August 23, 2023 06:29
@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #636 (ad5fa8b) into main (b13b187) will decrease coverage by 0.05%.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #636      +/-   ##
==========================================
- Coverage   27.43%   27.38%   -0.05%     
==========================================
  Files        1513     1515       +2     
  Lines      164343   164617     +274     
  Branches     3841     3843       +2     
==========================================
  Hits        45080    45080              
- Misses     118175   118449     +274     
  Partials     1088     1088              
Flag Coverage Δ
web 25.71% <0.00%> (-0.06%) ⬇️
web-beta 25.71% <0.00%> (-0.06%) ⬇️
web-classic 25.71% <0.00%> (-0.06%) ⬇️
web-utils 25.71% <0.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...rc/beta/components/fields/PropertyFields/index.tsx 0.00% <0.00%> (ø)
.../src/beta/components/fields/SpacingInput/index.tsx 0.00% <0.00%> (ø)
...eta/components/fields/common/NumberInput/index.tsx 0.00% <0.00%> (ø)
web/src/beta/components/fields/index.tsx 0.00% <0.00%> (ø)
...a/features/Editor/StoryPanel/ActionPanel/index.tsx 0.00% <0.00%> (ø)

@nina992 nina992 changed the title feat(web): add spacing input field feat(web): add spacing input field and number input Aug 30, 2023
@nina992 nina992 merged commit f921133 into main Sep 1, 2023
16 checks passed
@nina992 nina992 deleted the feat/add-spaing-input-field branch September 1, 2023 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants